ci: Only show performance improvements and regressions details #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default. Makes the perf PR comment a bit more concise.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1906 +/- ##
=======================================
Coverage 93.19% 93.20%
=======================================
Files 110 110
Lines 35760 35763 +3
=======================================
+ Hits 33328 33333 +5
+ Misses 2432 2430 -2 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to a71e43d. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [196.68 ns 197.13 ns 197.60 ns]
change: [-0.6399% -0.2900% +0.0383%] (p = 0.10 > 0.05)
Found 19 outliers among 100 measurements (19.00%)
1 (1.00%) low mild
8 (8.00%) high mild
10 (10.00%) high severecoalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [238.72 ns 239.32 ns 239.96 ns]
change: [-0.7943% -0.4757% -0.1402%] (p = 0.00 < 0.05)
Found 14 outliers among 100 measurements (14.00%)
14 (14.00%) high severecoalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [237.80 ns 238.56 ns 239.48 ns]
change: [-3.2300% -1.5488% -0.4040%] (p = 0.02 < 0.05)
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) high mild
6 (6.00%) high severecoalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [216.92 ns 217.08 ns 217.25 ns]
change: [-8.2607% -2.7045% +0.6362%] (p = 0.46 > 0.05)
Found 9 outliers among 100 measurements (9.00%)
2 (2.00%) high mild
7 (7.00%) high severeRxStreamOrderer::inbound_frame(): 💚 Performance has improved. time: [118.48 ms 118.59 ms 118.71 ms]
change: [-1.7180% -1.5080% -1.3439%] (p = 0.00 < 0.05)
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mildtransfer/Run multiple transfers with varying seeds: Change within noise threshold. time: [119.15 ms 119.41 ms 119.67 ms]
thrpt: [33.424 MiB/s 33.498 MiB/s 33.572 MiB/s]
change:
time: [-0.9970% -0.6654% -0.3279%] (p = 0.00 < 0.05)
thrpt: [+0.3290% +0.6699% +1.0070%]
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mildtransfer/Run multiple transfers with the same seed: Change within noise threshold. time: [119.32 ms 119.53 ms 119.74 ms]
thrpt: [33.406 MiB/s 33.464 MiB/s 33.524 MiB/s]
change:
time: [-0.7724% -0.4782% -0.1806%] (p = 0.00 < 0.05)
thrpt: [+0.1810% +0.4805% +0.7785%]
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) low mild
1 (1.00%) high mild1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold. time: [1.1250 s 1.1379 s 1.1524 s]
thrpt: [86.773 MiB/s 87.880 MiB/s 88.886 MiB/s]
change:
time: [+0.6213% +3.9938% +7.2745%] (p = 0.04 < 0.05)
thrpt: [-6.7812% -3.8404% -0.6175%]
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [391.35 ms 394.70 ms 398.11 ms]
thrpt: [25.118 Kelem/s 25.335 Kelem/s 25.552 Kelem/s]
change:
time: [-0.7719% +0.3353% +1.5493%] (p = 0.57 > 0.05)
thrpt: [-1.5257% -0.3342% +0.7779%]
Client/server transfer resultsTransfer of 134217728 bytes over loopback.
|
martinthomson
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default. Makes the perf PR comment a bit more concise. See below.